added cognito-to-descope migration skill#10
Open
mrunankpawar wants to merge 7 commits into
Open
Conversation
Contributor
|
🐕 Review complete — View session on Shuni Portal 🐾 |
Contributor
There was a problem hiding this comment.
🐕 Shuni's Review
Adds a new cognito-to-descope migration skill (~2,800 lines of guidance + reference docs).
Sniffed out 4 issues:
- 1 🟠 HIGH:
plugin.jsonversion not bumped perCLAUDE.md(new skill = minor bump →1.2.0) - 3 🟡 MEDIUM: incorrect Node SDK method name (
management.user.logoutdoesn't exist), wrong Python kwarg (logout_user(user_id=...)will TypeError), JWT payload decoded with'base64'instead of'base64url'
The 🟠 HIGH is a clear project-rule violation. The 🟡 MEDIUMs in IMPLEMENTATION-NOTES-DIST.md will lead users to write code that doesn't run — worth fixing before this lands so it can't propagate into customer migrations. Needs a bath!
Note on plugin.json: per CLAUDE.md, every PR must bump .claude-plugin/plugin.json. A new skill is a minor bump. Current version on this branch is still 1.1.1 (same as main); it should be 1.2.0.
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
reviewed
May 1, 2026
gaokevin1
requested changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This skill will be helpful for customers and prospects to help/guide them migrate from Cognito to Descope with any agent of their choice.