fix(outbound): add useDcr/dcrUrl to OutboundApplication type#747
Conversation
These fields were added to OutboundAppTemplateOverrides in #744 but not to OutboundApplication, forcing a cast when creating DCR-based outbound apps via createApplication. The REST create endpoint already accepts them, so this types create/update/load correctly with no cast.
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment strategy focused on recent contributors who have worked on the same or related files, ensuring they have relevant context and familiarity with the data types and test structures involved in this PR. This approach promotes efficient and knowledgeable reviews.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds optional useDcr/dcrUrl to the OutboundApplication type so DCR-based outbound apps can be created via createApplication without a cast.
No issues found — good bones! The fields mirror OutboundAppTemplateOverrides, createApplication spreads the payload through, and the new test verifies pass-through. Woof!
Related Issues
Fixes: #746
Changes
useDcr/dcrUrlto theOutboundApplicationtypecreateApplicationtest + README noteMust