Skip to content

fix(outbound): add useDcr/dcrUrl to OutboundApplication type#747

Merged
talaharoni merged 1 commit into
mainfrom
fix/outbound-app-dcr-types
Jun 22, 2026
Merged

fix(outbound): add useDcr/dcrUrl to OutboundApplication type#747
talaharoni merged 1 commit into
mainfrom
fix/outbound-app-dcr-types

Conversation

@talaharoni

@talaharoni talaharoni commented Jun 22, 2026

Copy link
Copy Markdown
Member

Related Issues

Fixes: #746

Changes

  • Add useDcr/dcrUrl to the OutboundApplication type
  • Adds a createApplication test + README note

Must

  • Tests
  • Documentation (if applicable)

These fields were added to OutboundAppTemplateOverrides in #744 but not to
OutboundApplication, forcing a cast when creating DCR-based outbound apps via
createApplication. The REST create endpoint already accepts them, so this types
create/update/load correctly with no cast.
@shuni-bot-dev

shuni-bot-dev Bot commented Jun 22, 2026

Copy link
Copy Markdown

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot-dev

shuni-bot-dev Bot commented Jun 22, 2026

Copy link
Copy Markdown

🐕 Suggested Reviewers

The review assignment strategy focused on recent contributors who have worked on the same or related files, ensuring they have relevant context and familiarity with the data types and test structures involved in this PR. This approach promotes efficient and knowledgeable reviews.

Reviewer Reason
aviadl Recent contributor to multiple files including the main type definitions and tests, indicating familiarity with the impacted areas.
oruis123 Contributed to similar files as aviadl and has recent experience modifying outboundapplication.test.ts and types.ts, making them well-suited for reviewing the changes.
dorsha Contributed to key files such as types.ts, providing relevant expertise in the data structures and types involved.
asmshshen Contributed to the types.ts file, helpful for reviewing the modifications to the OutboundApplication type and related types.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot-dev shuni-bot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds optional useDcr/dcrUrl to the OutboundApplication type so DCR-based outbound apps can be created via createApplication without a cast.

No issues found — good bones! The fields mirror OutboundAppTemplateOverrides, createApplication spreads the payload through, and the new test verifies pass-through. Woof!

@talaharoni talaharoni merged commit 9d4c506 into main Jun 22, 2026
28 checks passed
@talaharoni talaharoni deleted the fix/outbound-app-dcr-types branch June 22, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OutboundApplication (createApplication) is missing useDcr/dcrUrl — but OutboundAppTemplateOverrides has them, forcing a cast for DCR apps

2 participants