Skip to content

Disable renovate #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilgapira merged 1 commit into from
May 12, 2026
Merged

Disable renovate #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/export/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ runs:
using: 'composite'
steps:
- name: Install Descope CLI
uses: descope/descopecli/.github/actions/install@9163e884e1c1af93784b265a3dc048f4040b63ad # main
uses: descope/descopecli/.github/actions/install@main

@shuni-bot-dev shuni-bot-dev Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM: Switching from a pinned SHA to @main for the nested install action breaks reproducibility for downstream consumers.

export and import are marketplace composite actions (note the branding: block). When an external user pins descope/descopecli/.github/actions/export@<sha-or-tag>, the action.yml at that version will still resolve install@main at runtime — so any change on main (Go version bump, install logic change, or a malicious push) immediately affects every pinned consumer. The previous SHA-pin + Renovate pattern provided immutable refs and supply-chain hardening; disabling Renovate without keeping SHA pins removes both.

If the goal is just to stop the Renovate PR churn, consider keeping the SHA pin and updating it manually on release, or pinning to a tag (e.g. @v0.8.14) that moves on intentional cuts rather than every main commit.

with:
version: ${{ inputs.descopecli_version }}

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/import/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ runs:
using: 'composite'
steps:
- name: Install Descope CLI
uses: descope/descopecli/.github/actions/install@9163e884e1c1af93784b265a3dc048f4040b63ad # main
uses: descope/descopecli/.github/actions/install@main

@shuni-bot-dev shuni-bot-dev Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM: Same concern as export/action.yml:36 — install@main floats for every downstream consumer that pins this composite action to a tag or SHA. Any change on main propagates immediately to all pinned users, undermining the reproducibility and supply-chain guarantees that pinning is meant to provide.

with:
version: ${{ inputs.descopecli_version }}

Expand Down
3 changes: 2 additions & 1 deletion renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"local>descope/renovate-config"
]
],
"enabled": false
Comment on lines +5 to +6
}
Loading