Skip to content

feat(http): also retry on transient status code 520 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorsha merged 2 commits into from
Jun 22, 2026
+4 −4
Merged

feat(http): also retry on transient status code 520 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fcfc45
feat(http): also retry on transient status code 520
dorsha Jun 22, 2026
83015b0
fix(ci): revert phpunit to ^9.6.21 to match lockfile and PHP matrix
dorsha Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"vlucas/phpdotenv": "^5.6.1"
},
"require-dev": {
"phpunit/phpunit": "^12.0.0",
"phpunit/phpunit": "^9.6.21",
"squizlabs/php_codesniffer": "*"
},
"autoload": {
Expand Down
4 changes: 2 additions & 2 deletions src/SDK/API.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class API
{
private const RETRYABLE_STATUS_CODES = [503, 521, 522, 524, 530];
private const RETRYABLE_STATUS_CODES = [503, 520, 521, 522, 524, 530];

private $httpClient;
private $projectId;
Expand Down Expand Up @@ -244,7 +244,7 @@ public function generateJwtResponse(array $responseBody, ?string $refreshToken =

/**
* Executes an HTTP request callable, retrying on transient status codes
* (503, 521, 522, 524, 530) with delays of 100ms, 5s, 5s.
* (503, 520, 521, 522, 524, 530) with delays of 100ms, 5s, 5s.
* Non-retryable RequestExceptions are re-thrown immediately.
*
* @param callable $requestFn Zero-argument callable that performs the Guzzle request.
Expand Down
2 changes: 1 addition & 1 deletion src/tests/APIRetryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function testRetriesOnRetryableStatusCodeAndSucceedsOnSecondAttempt(int $

public static function retryableStatusCodeProvider(): array
{
return [[503], [521], [522], [524], [530]];
return [[503], [520], [521], [522], [524], [530]];
}

public function testRetriesUpToThreeTimesAndThrowsOnExhaustion(): void
Expand Down