feat: support multiple databases#44
Open
omercnet wants to merge 31 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
21 issues found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/server/http_helpers.go">
<violation number="1" location="internal/server/http_helpers.go:81">
P3: writeJSON silently discards json.Encoder.Encode error. If encoding fails mid-stream (e.g., broken connection or unsupported value type), the response is already committed with the status code and there's no diagnostic log.</violation>
</file>
<file name="internal/server/middleware.go">
<violation number="1" location="internal/server/middleware.go:38">
P3: CSP style-src 'unsafe-inline' weakens the policy by permitting arbitrary inline styles (enables CSS-based data exfiltration attacks). Consider nonce- or hash-based style-src if feasible.</violation>
</file>
Note: This PR contains a large number of files. cubic only reviews up to 40 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
There was a problem hiding this comment.
4 issues found across 22 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
omercnet
force-pushed
the
feat/multi-database-support
branch
from
25ad62e to
5c5a684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?db=<id>routing for DB-bound API endpointsValidation
GOTOOLCHAIN=go1.26.4 PATH="$(go env GOPATH)/bin:$PATH" make ciNotes
DATABASE_URL.db; saved-query CRUD remains database-independent.