Farabi/grwt-9079/add-positions-banner-and-modal#667
Open
farabi-deriv wants to merge 1 commit into
Open
Conversation
Contributor
|
Preview Link: https://farabi-grwt-9079-add.bot-65f.pages.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "positions banner" feature that notifies users about the upcoming Deriv Bot upgrade and prompts them to review and close their positions before the scheduled date. The implementation includes desktop and mobile banners, a mobile-only modal, and logic to defer onboarding tours and guides until the user has seen or dismissed the upgrade notice.
Key changes:
Positions Banner Feature
PositionsBanner(desktop),PositionsBannerMobile(mobile), andPositionsBannerModal(mobile modal) components, each displaying upgrade information and linking to the reports page. The modal is shown only once per browser and persists its seen state inlocalStorage.State Management and Integration
usePositionsBannerSeenhook andmarkPositionsBannerSeenutility for tracking and broadcasting the modal's seen state across components and tabs. (use-positions-banner-seen.tssrc/components/positions-banner/use-positions-banner-seen.tsR1-R40)Onboarding and Tour Deferral
These changes ensure all users are clearly notified about the upcoming system upgrade and are guided to review their positions, while also preventing onboarding distractions until the notice has been seen.