don't add comments when unbound#17
Open
ile wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a suggestion for a feature and the implementation may not be correct. Take it as an idea if you will.
What this does is avoid adding comments like
<!--unescaped unbound hello.message-->when the path is unbound and unescaped.The motivation for this is that 1) these comments are making the life hard in some cases 2) if the path is unbound, I don't think these comments need to be there?
For 1) the case is when I'm making a html editor and I'm using
unbound unescapedto make the html snippet editable, the extra comments are something extra that I would like to avoid.