fix(dao): remove duplicate meta/v1 import in table.go#575
Closed
ykgoesdumb wants to merge 1 commit into
Closed
Conversation
internal/dao/table.go imported k8s.io/apimachinery/pkg/apis/meta/v1 twice, as both metav1 and v1. Drop the redundant v1 alias and use metav1 consistently (staticcheck ST1019).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/dao/table.go imports
k8s.io/apimachinery/pkg/apis/meta/v1twice, once asmetav1and once asv1(staticcheck ST1019). This drops the redundantv1alias and usesmetav1consistently forIncludeObject.No behavior change. Verified with
go build ./...,go vet ./..., and staticcheck (the ST1019 warning on table.go is gone).