PHPStan: cleanup setup#4222
Merged
Merged
Conversation
staabm
commented
May 21, 2026
Comment on lines
+15
to
+19
| dynamicConstantNames: | ||
| DEPLOYER_VERSION: string | ||
| DEPLOYER_BIN: string | ||
| MASTER_ENDPOINT: string | ||
| MASTER_TOKEN: string |
Contributor
Author
There was a problem hiding this comment.
make PHPStan aware which types we expect the constants to have. those will be validated against when code uses define() or const.
see
staabm
commented
May 21, 2026
| - "#^Constant DEPLOYER_VERSION not found\\.$#" | ||
| - "#^Constant DEPLOYER_BIN not found\\.$#" | ||
| - "#^Constant MASTER_ENDPOINT not found\\.$#" | ||
| - "#^Constant MASTER_TOKEN not found\\.$#" |
Contributor
Author
There was a problem hiding this comment.
DEPLOYER_VERSION, DEPLOYER_BIN will be detected by phpstan bootstrap.
MASTER_ENDPOINT, MASTER_TOKEN are only conditionally defined, therefore still needs the ignore
staabm
commented
May 21, 2026
| use function Deployer\Support\normalize_line_endings; | ||
|
|
||
| /** | ||
| * @implements \ArrayAccess<string, mixed> |
Contributor
Author
There was a problem hiding this comment.
reflects the signature of
function set(string $name, mixed $value)
staabm
commented
May 21, 2026
| @@ -0,0 +1,8 @@ | |||
| <?php | |||
|
|
|||
| define('DEPLOYER_BIN', __DIR__ . '/../bin/dep'); | |||
Contributor
Author
There was a problem hiding this comment.
extracting constant definitions in a separate file, so PHPStan can discover them
antonmedv
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaning up tooling setup to ignore less errors. preparing the way to raise to level 6 in a followup