Added linux os requirement within node selectors#164
Open
pgarousi wants to merge 4 commits into
Open
Conversation
tsipo
reviewed
Jul 14, 2026
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
| nvidia.com/gpu.present: "true" | ||
| {{- with .Values.nodeSelector }} |
Member
There was a problem hiding this comment.
If I am not mistaken, the node selector values have to override the default ones. Typically the Nvidia GPU operator (node discovery feature) will place the nvidia.com/gpu.present: "true" label on each node with Nvidia GPUs. But in case it does not run and/or configured differently, this label may not be there. There was a request to allow us to override the node selector (not to append to them). Or we can keep the OS label and made the other ones overridable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.