Update nghttp2 to v1.69.0#6
Merged
Merged
Conversation
Bumps the nghttp2 submodule from v1.68.0 to v1.69.0 and updates the crate version to match. Verified `cargo build --all-features` and `cargo test --all-features` (16 tests) succeed against the new sources. Closes denoland/orchid#251 Co-Authored-By: Divy Srivastava <me@littledivy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nghttp2submodule from v1.68.0 to v1.69.0 (upstream release notes)Cargo.tomlto matchThe upstream release mainly touches
nghttpx(proxy server) and tooling that the Rust binding does not consume. The relevant change for the C library that we link against is the "Add missing iframe state validation" correctness fix (nghttp2/nghttp2#2643).Why this is a manual bump
The scheduled
update-nghttp2.ymlworkflow was auto-disabled by GitHub after 60 days of repo inactivity (the gap between72c7770and PR #5 tripped thedisabled_inactivitythreshold), so the weekly auto-bump did not fire. Submitting the bump directly was cleaner than re-enabling and dispatching the workflow.Verification
No changes to
build.rsor the source/header lists were needed — every file referenced bybuild.rsstill exists in v1.69.0.Test plan
cargo build --all-features(Linux)cargo test --all-features(16 integration tests pass)rust.ymlmatrix (Linux / macOS / Windows)Closes denoland/orchid#251