This repository was archived by the owner on Apr 2, 2026. It is now read-only.
refactor: Factor out stalled top-level await reporting#46
Merged
Conversation
mmastrac
reviewed
Jul 19, 2023
| let msg = v8::Local::new(scope, messages[0].clone()); | ||
| let js_error = JsError::from_v8_message(scope, msg); | ||
| return Poll::Ready(Err(js_error.into())); | ||
| let known_realms = self.inner.state.borrow().known_realms.clone(); |
Contributor
There was a problem hiding this comment.
I'm not sure about this one -- this will be extremely expensive even in an error path. Can we pass the slice into find_and_report_stalled_level_await_in_any_realm instead?
mmastrac
approved these changes
Jul 19, 2023
mmastrac
left a comment
mmastrac
left a comment
Contributor
There was a problem hiding this comment.
One minor thing for the error path -- replace Vec w/slice
Member
Author
|
Ooops, I just noticed the comment - I had auto-merge enabled. I'll look into fixing the clone here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #41.