This repository was archived by the owner on Apr 2, 2026. It is now read-only.
refactor: Move ModuleMap to JsRealm#45
Merged
bartlomieju merged 4 commits intoJul 19, 2023
Merged
Conversation
Member
Author
Comment on lines
1621
to
1623
| // `self.module_map` points directly to the v8 isolate data slot, which | ||
| // we must explicitly drop before destroying the isolate. We have to | ||
| // take and drop this `Rc` before that. |
Contributor
There was a problem hiding this comment.
This comment should probably be removed now.
bartlomieju
force-pushed
the
move_module_map_to_jsrealm
branch
from
71b7c71 to
3b1e526
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #41.
Now all
JsRealminstances have aModuleMap, but only the "main realm"ModuleMapis being used.