port to oxc#331
Open
nathanwhit wants to merge 17 commits into
Open
Conversation
|
|
Bumps the oxc dependency to 0.134. Notable changes handled: - `DecoratorOptions` gained a `strict_null_checks` field. - The string types (`Atom`/`Ident`/`CompactStr`) moved from `oxc_span` to the new `oxc_str` crate, and the AST's string-literal value type changed from `Atom` to `Str`. Add an `oxc_str` dependency and re-export the string types through `deno_ast::oxc::span` so downstream imports keep working. Requires Rust 1.96 (oxc_transformer uses stabilized `if let` guards).
When parsing with `scope_analysis: true`, run `SemanticBuilder` and store the resulting `Scoping` on `ParsedSource` (exposed via `scoping()` / `take_scoping()`). Semantic analysis also populates the symbol/reference ids on the AST nodes. This is the oxc equivalent of swc's resolver pass and lets consumers (e.g. deno_graph's symbol analyzer) distinguish same-named identifiers across scopes.
This was referenced Jun 3, 2026
|
Can I help on this? Seems interesting |
|
What's the benefit of doing this? Genuine question. |
@iuioiua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done by claude, needs closer review