feat: ES module snapshotting#17460
Merged
Merged
Conversation
bartlomieju
reviewed
Jan 18, 2023
Member
There was a problem hiding this comment.
I think it's safe to skip handling of modules in non-global realms, would you agree @andreubotella?
Contributor
I guess that depends on the use case for module snapshotting. For However, in this use case it would probably be good to make sure that any non-GC'd realms have an empty module map when snapshotting. If this PR lands before #15760 I'll make sure to add that check. |
Co-authored-by: Andreu Botella <andreu@andreubotella.com>
bartlomieju
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for snapshotting ES modules. This is done by
adding an ability to serialize and deserialize a "ModuleMap" and attach it
to the snapshot, using "add_context_data" API.
This has been tested with 400 modules and seems to not have a limit on
the number of modules that might be snapshotted.