Skip to content

Add "Flakeless Parts" template#96

Merged
theutz merged 9 commits into
denful:mainfrom
theutz:flakeless-parts
Apr 10, 2026
Merged

Add "Flakeless Parts" template#96
theutz merged 9 commits into
denful:mainfrom
theutz:flakeless-parts

Conversation

@theutz
Copy link
Copy Markdown
Collaborator

@theutz theutz commented Apr 10, 2026

First, I don't love the name. 😄 npins-flake-parts? flake-parts-npins? nparts? I couldn't come up with anything. Feel free to change it.

More importantly, I was able to get npins and flake-file to play nicely, but I had to create a new module to do it cleanly. So, while this is mostly a change to the templates, there is an addition to the API.

Let me know what you think!

@vic
Copy link
Copy Markdown
Member

vic commented Apr 10, 2026

CI is failing

nix run .#write-flake -L --show-trace --override-input flake-file "github:$GITHUB_REPOSITORY/$GITHUB_SHA"
warning: input '' has an override for a non-existent input 'flake-file'
warning: the flag '--override-input flake-file github:vic/flake-file/2514b92896580e5e24d2feaaf5f27fea3fd8196c' does not match any input

looks like it cannot override the flake-file input to make it the commit version

Comment thread templates/flakeless-parts/default.nix
Comment thread .github/workflows/flake-check.yaml
@theutz
Copy link
Copy Markdown
Collaborator Author

theutz commented Apr 10, 2026

Oh, wait. It's not failing that test. It's getting pulled into the matrix test, which it would fail. And probably shouldn't be used. Is there a way to filter it out?

nvm, I think I found it.

@theutz theutz requested a review from vic April 10, 2026 16:47
@theutz
Copy link
Copy Markdown
Collaborator Author

theutz commented Apr 10, 2026

AND, I forgot about YAML sequences. Can you push the button again, @vic ?

vic
vic previously approved these changes Apr 10, 2026
@theutz
Copy link
Copy Markdown
Collaborator Author

theutz commented Apr 10, 2026

After actually reading the GitHub Actions docs for the matrix strategy, I think I figured out what I was doing wrong and why the minimal test was running. Hoping this one fixes it.

Copy link
Copy Markdown
Member

@vic vic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge yourself when ready.

@theutz theutz self-assigned this Apr 10, 2026
@theutz
Copy link
Copy Markdown
Collaborator Author

theutz commented Apr 10, 2026

Ok! Finally saw the actually relevant test turn green. I'm going for it!

@theutz theutz merged commit 24bcb32 into denful:main Apr 10, 2026
12 checks passed
@theutz theutz deleted the flakeless-parts branch April 10, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants