Add "Flakeless Parts" template#96
Merged
Merged
Conversation
Member
|
CI is failing looks like it cannot override the flake-file input to make it the commit version |
vic
requested changes
Apr 10, 2026
theutz
commented
Apr 10, 2026
Collaborator
Author
|
nvm, I think I found it. |
Collaborator
Author
|
AND, I forgot about YAML sequences. Can you push the button again, @vic ? |
vic
previously approved these changes
Apr 10, 2026
Collaborator
Author
|
After actually reading the GitHub Actions docs for the matrix strategy, I think I figured out what I was doing wrong and why the minimal test was running. Hoping this one fixes it. |
vic
approved these changes
Apr 10, 2026
Member
vic
left a comment
There was a problem hiding this comment.
Please merge yourself when ready.
Collaborator
Author
|
Ok! Finally saw the actually relevant test turn green. I'm going for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I don't love the name. 😄
npins-flake-parts?flake-parts-npins?nparts? I couldn't come up with anything. Feel free to change it.More importantly, I was able to get npins and flake-file to play nicely, but I had to create a new module to do it cleanly. So, while this is mostly a change to the templates, there is an addition to the API.
Let me know what you think!