Skip to content

fix(build-rootfs): skip docker pull when the image is already local #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WaylandYang merged 2 commits into from
Jun 14, 2026
Merged

fix(build-rootfs): skip docker pull when the image is already local #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17ec1d
fix(build-rootfs): skip docker pull when the image is already local
WaylandYang Jun 14, 2026
c300833
Merge branch 'main' into fix/build-rootfs-local-image-pull
WaylandYang Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/build-rootfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ say "work dir: $WORK"

# ----------------------------------------------------------------------------
say "[1/5] pulling + creating container..."
docker pull -q "$IMAGE"
# Skip the registry pull when the image already exists locally — e.g. a
# recipe-built wrapped image (coding-agent tags one as
# forkd-coding-agent:tmp-$$). Pulling such a local-only tag forces a
# needless registry round-trip that 429s behind a throttled mirror and
# aborts the build.
docker image inspect "$IMAGE" >/dev/null 2>&1 || docker pull -q "$IMAGE"
docker create --name "$CONTAINER" "$IMAGE" /bin/true >/dev/null

# ----------------------------------------------------------------------------
Expand Down
Loading