docs(setup-host): explain why curl-pipe-sh rustup install is safe here — closes #236#237
Merged
Merged
Conversation
…e — #236 @jelloee filed #236 noting that scripts/setup-host.sh's curl-pipe-sh rustup install lacks a checksum or version pin. Accurate observation, but the supply-chain risk is bounded by `rust-toolchain.toml` at the repo root — rustup-init only installs the rustup binary; the toolchain forkd actually compiles with is fetched from rust-lang.org and pinned by the toml. So even a sh.rustup.rs compromise wouldn't pick the project's compiler. Adding a comment explaining this so future readers don't re-raise the same concern. Also notes a possible future `--paranoid` mode that downloads rustup-init + verifies sha256 — deferred because the sha256 needs refreshing on every rustup-init release, which trades supply- chain hygiene for maintenance staleness. Closes #236. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@jelloee opened #236 noting that
scripts/setup-host.sh:40does the textbook curl-pipe-sh rustup install with no checksum and no version pin. Accurate read — but the supply-chain risk is bounded byrust-toolchain.tomlat the repo root: rustup-init only installs therustupbinary; the compiler forkd actually builds with is fetched from rust-lang.org per the toml, regardless of whatsh.rustup.rsreturns.This PR adds a comment block above the install line explaining that, so future readers don't re-raise the same concern. Also notes a deferred future option (
--paranoidmode that downloads rustup-init + verifies sha256) and why I'm not doing it now (sha256 needs refreshing on every rustup-init release).Diff
One file, comment only, no behavior change.
Test plan
Closes #236.
Thanks again to @jelloee for the thoughtful first report — exactly the kind of low-severity-but-clearly-reasoned issue that's worth replying to with reasoning, not just closing.
🤖 Generated with Claude Code