Skip to content

Fix: auto update user_data to avoid Signature Invalidation in Laravel-websocket #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saadjavaid67 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: auto update user_data to avoid Signature Invalidation in Laravel-websocket #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/pysher/pusher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def subscribe(self, channel_name, auth=None):
if auth is None:
if channel_name.startswith('presence-'):
data['auth'] = self._generate_presence_token(channel_name)
data['channel_data'] = json.dumps(self.user_data)
data['channel_data'] = self.user_data if isinstance(self.user_data, str) else json.dumps(self.user_data)
elif channel_name.startswith('private-'):
data['auth'] = self._generate_auth_token(channel_name)
else:
Expand Down Expand Up @@ -208,7 +208,12 @@ def _generate_presence_token(self, channel_name):
headers=self.auth_endpoint_headers
)
assert response.status_code == 200, f"Failed to get auth token from {self.auth_endpoint}"
auth_key = response.json()["auth"]
response_data = response.json()
auth_key = response_data["auth"]
try:
self.user_data = response_data["channel_data"]
except KeyError:
pass
return auth_key

def _build_url(self, secure=True, port=None, custom_host=None):
Expand Down