Skip to content

Improved Error Logging on Rate Limiting #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoritzLeubner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improved Error Logging on Rate Limiting #436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c474f7
Replaced meaningless 'No results found.' with clear error message
MoritzLeubner Mar 24, 2026
7562264
Handle additional HTTP error statuses in request method
MoritzLeubner Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ddgs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ def request(self, *args: Any, **kwargs: Any) -> str | None: # noqa: ANN401
resp = self.http_client.request(*args, **kwargs)
if resp.status_code == 200:
return resp.text
return None
elif resp.status_code in (403, 429, 202):
raise ValueError(f"Request blocked with status code {resp.status_code} by rate limiting or anti-bot measures")
else:
raise ValueError(f"Request failed with status code {resp.status_code}")

@cached_property
def parser(self) -> LHTMLParser:
Expand Down Expand Up @@ -119,6 +122,6 @@ def search(
else:
html_text = self.request(self.search_method, self.search_url, data=payload)
if not html_text:
return None
raise ValueError("Empty response")
results = self.extract_results(html_text)
return self.post_extract_results(results)