fix: Incorrect Base64URL encoding used#24
Conversation
kdenhartog
left a comment
kdenhartog
left a comment
There was a problem hiding this comment.
@awoie who's the best one at uPort to look at this and make sure it won't break anything for you guys?
|
just noting, I'll bring this up on the next DID-Auth call, so we can get this through ASAP without breaking anyone. When this was discussed in the Aries WG, we recognized it was a breaking change but accepted "everyone" (that we know of at least) would move in that direction. The one who I'm thinking may depend on this package is uPort which is why I want to make sure they have someone aware of this. |
|
Thank you for your reply. |
From our end @mirceanis will be mostly involved in everything that is related to the DIDComm implementation. We should be fine with this PR but let's discuss on the next DID Auth Call. |
|
@awoie @kdenhartog |
3 participants
Fixed #21