fix: event cards animation#417
Open
juanmahidalgo wants to merge 1 commit into
Open
Conversation
Deploying ui2 with
|
| Latest commit: |
b8e638b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9db691ae.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-events-card-shifting.ui2-423.pages.dev |
decentraland-bot
approved these changes
Apr 1, 2026
Contributor
decentraland-bot
left a comment
decentraland-bot
left a comment
There was a problem hiding this comment.
Review: fix: event cards animation
Summary
Clean simplification PR — removes hover animations from the EventCard component:
EventCardMedia: Removed thehoverHeightprop and the hover height transition. The image no longer shrinks on hover.AvatarAndLocationRow: Removed the hovermargin-bottomtransition that shifted the row down to make room for the Jump In button.LeftBadge: Added amaxWidth: '70%'constraint on small screens — prevents the badge from overflowing on narrow viewports.
Analysis
- No bugs or logic issues found.
JUMP_IN_BUTTON_HEIGHTconstant is still used for theJumpInButtonheight (line 297), so no dead code introduced.hoverHeightprop removed from the styled component type — clean, no leftover references.- The responsive breakpoint addition on
LeftBadgeis a nice touch for mobile.
Security
No security issues found. Pure styling changes with no user input, APIs, or data handling involved.
CI
All checks passing ✅
LGTM 👍
Requested by Juan Manuel Hidalgo via Slack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.