Fix compatibility with EZ2DJ titles.#7
Open
ben-rnd wants to merge 5 commits into
Open
Conversation
SetVolume(0) should set max volume not mute. Per docs volume range is -10000 (min) to 0 (max): https://learn.microsoft.com/en-us/previous-versions/windows/desktop/mt708939(v=vs.85)#remarks
EZ2DJ uses looping streams as a circular buffer for playing longer audio files for most BGMs. looping stream was being removed before next write, causing audio to go silent. As per dsound docs a looping buffer should only stop when stopped explicitly. https://learn.microsoft.com/en-us/previous-versions/windows/desktop/ee418074(v=vs.85)#parameters
EZ2DJ likes to spam play() on a few buffers. this was causing terrible audio most notably on the name entry screen. Per direct sound docs, subsequent play()'s should only update the flag. https://learn.microsoft.com/en-us/previous-versions/windows/desktop/ee418074(v=vs.85)#remarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some changes that fixed missing/broken functionality that prevented this from working with ez2dj