1089 full shore importer#1102
Draft
mew-nsc wants to merge 20 commits into
Draft
Conversation
…e data to confirm test failure resolution
Codecov Report
@@ Coverage Diff @@
## develop #1102 +/- ##
===========================================
+ Coverage 80.03% 80.33% +0.30%
===========================================
Files 110 111 +1
Lines 11889 12087 +198
===========================================
+ Hits 9515 9710 +195
- Misses 2374 2377 +3
Continue to review full report at Codecov.
|
IanMayo
reviewed
Dec 7, 2021
| state = datafile.create_state(data_store, self.platform, sensor, timestamp, self.short_name) | ||
|
|
||
| location = Location(errors=self.errors, error_type=self.error_type) | ||
| lat_degs = float(lat_token.text) * (180 / math.pi) |
Member
There was a problem hiding this comment.
It may be neater to use Python's math.degrees() function (as we do in the eag_importer). This will make it easier to track instances where we're converting from radians to degrees.
Contributor
Author
|
This PR is left open as a draft PR pending answers about the units that the format uses. The code as written assumes some units:
These will need confirming before this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Issue
Fixes #1089
🚀 Overview:
Created an importer for the CSV output of the full shore / DNA format
🤔 Reason:
To allow Full Shore / DNA data to be imported into Pepys
🔨Work carried out:
Confirmations
interactive_reviewif reviewers will need to see UI\docsfolderalembic revisiontransitions