docs(schema): purge stale bbox/zoom/center SystemState-spatial refs (#266)#660
Merged
Conversation
…266) Tech-debt follow-up to #249/spec-261, which unified SystemStateProperties.spatial onto `viewport: ViewportPolygon` (+ optional `rotation`), removing the legacy `bbox: float[4]` / `zoom: float` / `center: float[2]` fields. Updates every remaining doc that still described the old shape: - shared/schemas/README.md — state.spatial variant line - specs/237-active-storyboard-persistence/data-model.md — SystemStateTypeEnum.spatial desc - specs/022-system-kind-discriminator/ (the spec that originally defined the shape): spec.md (acceptance criterion + Key Entities + a "superseded by #261" note), research.md (rationale), data-model.md (field table + validation rule), evidence/usage-example.md (Python snippet), evidence/sample-spatial.json (rewritten to the 4-corner polygon and re-validated against the live SystemState Pydantic model) Retained intentionally (different, current concepts): storyboard Viewport (center/zoom/bearing), STAC spatial.bbox, GeoJSON bbox members, ViewportPolygon.zoom. Marks BACKLOG #266 complete and logs the work in issues.md. https://claude.ai/code/session_019XNKPXw6XgxjrPx1nsGrNj
Contributor
📋 Backlog NavigatorReview this PR's BACKLOG.md edits interactively: Updated for d313b97 — the navigator reads BACKLOG.md live from this PR's head branch, so no rebuild is needed. |
Contributor
📋 Spec NavigatorReview this PR's specs interactively:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes BACKLOG #266 — the spatial-shape documentation cleanup that became actionable once #249 / spec-261 shipped.
Spec-261 unified
SystemStateProperties.spatialonto a singleviewport: ViewportPolygon(+ optionalrotation), removing the legacybbox: float[4]/zoom: float/center: float[2]fields. This PR purges every remaining doc that still described the old shape. Documentation + one evidence fixture only — no code, schema, or test-fixtures-under-test changed.What changed
shared/schemas/README.mdstate.spatialvariant line →ViewportPolygon + rotationspecs/237-active-storyboard-persistence/data-model.mdSystemStateTypeEnum.spatialdescription →(ViewportPolygon)specs/022-system-kind-discriminator/evidence/sample-spatial.json(rewritten to the 4-corner polygon)BACKLOG.mddocs/project_notes/issues.mdScope decision
The stale references clustered in the foundational, already-shipped spec-022. Per a scope check, the chosen approach was a full purge (clean grep), including the historical sample fixture, with a "superseded by #261" note added so readers understand why a 2024-era spec now shows the 2026 shape.
Retained intentionally (different, current concepts — not the removed SystemState shape): the storyboard
Viewporttype (center/zoom/bearing), STACspatial.bboxcollection extent, standard GeoJSONbboxmembers, and the newViewportPolygon.zoomslot.Verification
SystemStateProperties.*bbox,state_type.*spatial.*bbox, and(bbox, zoom[, center])all return zero SystemState hits (excluding spec-261's own migration docs).evidence/sample-spatial.jsonre-validated against the liveSystemStatePydantic model (viewport= 4 corners,zoom= 8.5,rotation= 0); confirmed no test references the file.ruff/pnpm lint/pnpm -r typecheckall green (the only lint warnings are pre-existing inapps/vscode/src/services/llmProxy.ts, untouched here).https://claude.ai/code/session_019XNKPXw6XgxjrPx1nsGrNj
Generated by Claude Code