Remove unused dataset setup in attention figure script#26
Open
relh wants to merge 1 commit into
Open
Conversation
I think the dataset gets redefined a few lines later but maybe we need the first initialization for the ViewSampler? not sure.. Probably something similar in the other fig files
Author
|
Also see a key error for overfit to scene but might be because only downloaded the subset of re10k. |
relh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attention figure script initialized the test dataset once, then immediately set up a different dataset path for the desired scene. The first initialization looked unused and made the setup more confusing.
This PR removes that earlier unused dataset initialization so the figure script only uses the dataset created for the selected scene.
Verification