Skip to content

Fix biometric test helpers to match post-lock navigation flow #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbro merged 1 commit into from
May 27, 2026
Merged

Fix biometric test helpers to match post-lock navigation flow #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pwa/tests/biometric.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ async function openVaultNoEnroll(page: Page) {
await expect(page.getByPlaceholder('Search vault')).toBeVisible({ timeout: 10000 })
}

// Lock the vault and wait for the landing screen.
// Lock the vault and wait for the unlock screen (recent handles restores file state).
async function lockVault(page: Page) {
await page.locator('.vault-pill').click()
await expect(page.locator('.vault-settings-body')).toBeVisible()
await page.getByRole('button', { name: /Lock vault/ }).click()
await expect(page.getByRole('button', { name: 'Open vault file' })).toBeVisible({ timeout: 5000 })
await expect(page.getByPlaceholder('Master password')).toBeVisible({ timeout: 5000 })
}

// ── tests ─────────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -170,6 +170,8 @@ test.describe('Biometric/PIN unlock', () => {
await openVaultAndEnroll(page)
await lockVault(page)

// Return to landing screen (lockVault leaves us on the unlock screen)
await page.getByRole('button', { name: 'Open a different vault' }).click()
// Create a brand-new vault — no fast unlock enrollment for it
await page.getByRole('button', { name: 'Create one' }).click()
await page.getByPlaceholder('Master password').fill('newpassword')
Expand All @@ -186,7 +188,8 @@ test.describe('Biometric/PIN unlock', () => {
await openVaultAndEnroll(page)
await lockVault(page)

// Re-open file — fast unlock button should appear for three.dat
// Mock handle can't survive IDB serialization, so re-pick the file to restore state
await page.getByRole('button', { name: 'Open a different vault' }).click()
await page.getByRole('button', { name: 'Open vault file' }).click()
await expect(page.locator('.btn-biometric')).toBeVisible({ timeout: 5000 })

Expand All @@ -205,6 +208,8 @@ test.describe('Biometric/PIN unlock', () => {
await openVaultAndEnroll(page)
await lockVault(page)

// Mock handle can't survive IDB serialization, so re-pick the file to restore state
await page.getByRole('button', { name: 'Open a different vault' }).click()
await page.getByRole('button', { name: 'Open vault file' }).click()
await expect(page.locator('.btn-biometric')).toBeVisible({ timeout: 5000 })

Expand Down
7 changes: 5 additions & 2 deletions pwa/tests/readonly_vault.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async function lockVault(page: Page) {
await page.locator('.vault-pill').click()
await expect(page.locator('.vault-settings-body')).toBeVisible()
await page.getByRole('button', { name: /Lock vault/ }).click()
await expect(page.getByRole('button', { name: 'Open vault file' })).toBeVisible({ timeout: 5000 })
await expect(page.getByPlaceholder('Master password')).toBeVisible({ timeout: 5000 })
}

// ── tests ─────────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -200,7 +200,8 @@ test.describe('Biometric/PIN unlock on fallback path (iOS)', () => {

await lockVault(page)

// Re-select the same file — biometric button should appear
// Navigate back to landing, then re-select the same file — biometric button should appear
await page.getByRole('button', { name: 'Open a different vault' }).click()
const [fc2] = await Promise.all([
page.waitForEvent('filechooser'),
page.getByRole('button', { name: 'Open vault file' }).click(),
Expand Down Expand Up @@ -230,6 +231,8 @@ test.describe('Biometric/PIN unlock on fallback path (iOS)', () => {

await lockVault(page)

// Navigate back to landing, then re-select the same file
await page.getByRole('button', { name: 'Open a different vault' }).click()
const [fc2] = await Promise.all([
page.waitForEvent('filechooser'),
page.getByRole('button', { name: 'Open vault file' }).click(),
Expand Down
Loading