Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR
Summary
Reasoning
DNSSEC protects the domain’s DNS delegation from tampering. mTLS ensures the ALB only accepts requests authenticated with our Cloudflare certificate, blocking direct-origin traffic—and traffic proxied through another Cloudflare account—before it reaches the application. Automated certificate rotation keeps this manageable across many projects.
Changelog
New
Route 53 Domains DNSSEC registration (
aws/route53domains-dnssec)Registers an external DNS provider's DNSSEC key (e.g. Cloudflare's KSK) with a domain registered in Route 53 Domains, completing the chain of trust. Integrated into
stack/appbehind the opt-inroute53domains_dnssec_enabledvariable (defaultfalse). If your domain already has a manually registered DNSSEC key, import it before enabling — see the module README.mTLS between Cloudflare and the ALB (
aws/alb-mtls)Cloudflare Authenticated Origin Pulls with a custom per-zone client certificate, verified by the ALB against an S3-backed trust store. Prevents attackers from bypassing Cloudflare and hitting the ALB directly. New stack variables:
alb_mtls_ca_certificates_pem,alb_mtls_mode,authenticated_origin_pull. Helper scripts:script/generate-mtls-certs.sh,script/rotate-mtls-certificates.sh. Read the rollout warning inaws/alb-mtls/README.mdbefore enabling on a live ALB — deploy Cloudflare first, thenpassthrough, thenverify.stack/appNew required provider alias
aws.us-east-1(Route 53 Domains API only exists in us-east-1). Every consumer ofstack/appmust pass it, even when not using DNSSEC: