feat!: replace regex route matching with URLPattern - #36
Merged
Conversation
BREAKING CHANGE: Deployment route patterns now use URLPattern syntax instead of glob-style patterns. Before: '*example.com/*' After: 'https://*.example.com/*' This eliminates the ReDoS vulnerability from regex-based matching and pre-compiles URLPattern instances at router creation time for better per-request performance. Key changes: - deployment-for-request.ts: replaced regex with URLPattern, added compileDeployments() for pre-compilation - cloudflare-router.ts: pre-compiles deployments at createRouter() time - with-auth.ts: accepts CompiledDeployment[] instead of reading from config - Updated all tests and README for new pattern syntax
Resolved conflicts in deployment-for-request.ts, cloudflare-router.ts, and with-auth.ts. Updated all tests from merged branches (colon passwords, IP auth, mixed auth) to use URLPattern syntax and the new 4-arg withAuth signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Deployment route patterns now use URLPattern syntax instead of glob-style patterns.
Before: 'example.com/'
After: 'https://.example.com/'
This eliminates the ReDoS vulnerability from regex-based matching and pre-compiles URLPattern instances at router creation time for better per-request performance.
Key changes: