feat(opencode-plugin): address Cubic PR #4 findings#25
Conversation
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
There was a problem hiding this comment.
All reported issues were addressed across 19 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
Summary by cubic
Improves reliability and safety across the Daytona plugin: shell-safe, per-repo serialized git operations; resilient sandbox reconnect/delete; safer on-disk storage; and clearer tool behavior. Fixes edge cases that caused failed syncs, stale sessions, or noisy errors.
Bug Fixes and Hardening
gitwithout a shell; serialize per-repo (git-common-dir, realpath) to avoid.git/config/index.lockraces; add retries; pull the sandbox’s actual branch and only reset if it’s checked out; in the sandbox usecheckout -f; fail fast if remote add/config fails.projectIdon disk viaencodeURIComponent, decode on list; migrate by writing destination first and verifying; add read-onlyfindSessionand use it on delete (no migration); on update refreshworktreebut preserve the canonicalprojectId; handleDaytonaNotFoundErroron reconnect/delete, preserve mappings on transient errors; delete returns a boolean and clears stale mappings.oldString, fail on missing/ambiguous matches), truncategrepto 100 matches with a note, validate previewport, report correct byte length on write, create bash exec session only when missing (rethrow non-404), and avoid duplicate error toasts on idle.~/.local/sharewhenXDG_DATA_HOMEis unset, trim logs by bytes (not chars), and make logging best-effort.Removals and Docs
lspandpatchtools; minor import cleanup and README updates on data path defaults, API key env var, and build/test instructions.Written for commit f5d8be2. Summary will update on new commits.