Skip to content

feat(opencode-plugin): address Cubic PR #4 findings#25

Merged
mislavivanda merged 5 commits into
mainfrom
opencode/quick-circuit
Jul 8, 2026
Merged

feat(opencode-plugin): address Cubic PR #4 findings#25
mislavivanda merged 5 commits into
mainfrom
opencode/quick-circuit

Conversation

@mislavivanda

@mislavivanda mislavivanda commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by cubic

Improves reliability and safety across the Daytona plugin: shell-safe, per-repo serialized git operations; resilient sandbox reconnect/delete; safer on-disk storage; and clearer tool behavior. Fixes edge cases that caused failed syncs, stale sessions, or noisy errors.

  • Bug Fixes and Hardening

    • Git: run git without a shell; serialize per-repo (git-common-dir, realpath) to avoid .git/config/index.lock races; add retries; pull the sandbox’s actual branch and only reset if it’s checked out; in the sandbox use checkout -f; fail fast if remote add/config fails.
    • Session/storage: sanitize projectId on disk via encodeURIComponent, decode on list; migrate by writing destination first and verifying; add read-only findSession and use it on delete (no migration); on update refresh worktree but preserve the canonical projectId; handle DaytonaNotFoundError on reconnect/delete, preserve mappings on transient errors; delete returns a boolean and clears stale mappings.
    • Tools/UX: validate edits (non-empty oldString, fail on missing/ambiguous matches), truncate grep to 100 matches with a note, validate preview port, report correct byte length on write, create bash exec session only when missing (rethrow non-404), and avoid duplicate error toasts on idle.
    • Paths/logging: fall back to ~/.local/share when XDG_DATA_HOME is unset, trim logs by bytes (not chars), and make logging best-effort.
  • Removals and Docs

    • Removed unused lsp and patch tools; minor import cleanup and README updates on data path defaults, API key env var, and build/test instructions.

Written for commit f5d8be2. Summary will update on new commits.

Review in cubic

Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread packages/opencode-plugin/.opencode/plugin/daytona/tools/edit.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/core/project-data-storage.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/tools/edit.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/core/project-data-storage.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/git/host-git-manager.ts Outdated
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/opencode-plugin/.opencode/plugin/daytona/core/project-data-storage.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/git/host-git-manager.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/core/project-data-storage.ts Outdated
Comment thread packages/opencode-plugin/.opencode/plugin/daytona/tools/multiedit.ts Outdated
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread packages/opencode-plugin/.opencode/plugin/daytona/git/host-git-manager.ts Outdated
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
@mislavivanda mislavivanda merged commit 88157a2 into main Jul 8, 2026
10 checks passed
@mislavivanda mislavivanda deleted the opencode/quick-circuit branch July 8, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant