Skip to content

harness(tuner): adaptive-nugget Cholesky retry for GP non-PD flake#2009

Open
dayfine wants to merge 1 commit into
mainfrom
harness/bayesian-gp-nugget-escalation
Open

harness(tuner): adaptive-nugget Cholesky retry for GP non-PD flake#2009
dayfine wants to merge 1 commit into
mainfrom
harness/bayesian-gp-nugget-escalation

Conversation

@dayfine

@dayfine dayfine commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Completes the adaptive-nugget Cholesky retry for the intermittent test_bayesian_opt.exe LAPACKE non-PD flake. Extracts the retry into bayesian_opt_cholesky.{ml,mli} (keeps bayesian_opt.ml <=300 lines per code-health-discipline — no @large-module marker) and adds a near-duplicate-observations guard test. Bit-identical on the Cholesky success path; only the non-PD failure path escalates a diagonal jitter. Closes the harness.md [~] LAPACKE item.

Test plan: dune build @fmt + dune build + dune runtest all exit 0 (incl. linter_file_length). New guard test asserts fit_gp succeeds on near-duplicate observations.

🤖 Dispatched by GHA orchestrator run 29689673403

Extracts the escalating-jitter Cholesky retry into bayesian_opt_cholesky.{ml,mli}
so bayesian_opt.ml stays under the 300-line soft limit, and adds a
near-duplicate-observations guard test pinning fit_gp against the intermittent
LAPACKE non-PD failure (test_bayesian_opt.exe). Bit-identical on the success path.

Fixes the residual test_bayesian_opt.exe `Failure("LAPACKE: 9")` CI flake.

@dayfine dayfine left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural QC

Verdict: APPROVED
Reviewed SHA: 1de25b4
Quality Score: 5

Hard gates (dune build @fmt / build / runtest) all exit 0, no FAIL lines (incl. linter_file_length — bayesian_opt.ml 297 lines, under the 300 soft limit). P6 test-patterns conformant. A1 PASS (no core-module touched — tuner lib/test only). A2 PASS (no analysis/ imports). A3 PASS (file list matches scope: bayesian_opt.{ml,mli}, new bayesian_opt_cholesky.{ml,mli}, test_bayesian_opt.ml, harness.md). Success path bit-identical (first attempt bare Linalg.chol); escalation only on a narrow LAPACKE non-PD Failure match.

Full checklist: dev/reviews/harness-bayesian-gp-nugget.md. (Posted as COMMENT — native approve blocked: reviewer identity == PR author.)

@dayfine dayfine left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavioral QC

Verdict: APPROVED
Reviewed SHA: 1de25b4
Quality Score: 4

Pure harness / numerical-stability PR — domain checklist (S*/L*/C*/T*) NA. Reviewed against Contract Pinning CP1-CP4 only: CP1 PASS, CP2 PASS, CP3 NA, CP4 PASS. Core contract "non-PD kernel -> escalating-jitter retry, does not raise, returns finite posterior" is pinned by test_fit_gp_near_duplicate_observations_does_not_raise; "success path unchanged" is structurally guaranteed (first attempt is a bare Linalg.chol on the unmodified kernel).

harness_gap (ONGOING_REVIEW, non-blocking): the retry-budget-exhaustion re-raise and non-PD-only discrimination are documented but not deterministically pinned — the guard test is BLAS-dependent as to whether it hits the retry path; a clean pin needs a stubbable Cholesky seam, impractical for a numerical flake-fix.

Full checklist: dev/reviews/harness-bayesian-gp-nugget.md.

dayfine added a commit that referenced this pull request Jul 19, 2026
Automated daily orchestrator run 2 (GHA run 29695173698). Main GREEN
(HEAD 6cd7637); ZERO dispatches — the sole run-1 actionable item
(LAPACKE fix) is now maintainer-LOCAL PR #2009, all other tracks blocked
(deep-warehouse-data-gated / human-gated / active-LOCAL). Since run-1:
#2005 (margin M1b-2) MERGED. Reconciled _index.md. See
dev/daily/2026-07-19-run2.md.

🤖 Generated by GHA orchestrator run 29695173698

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
dayfine pushed a commit that referenced this pull request Jul 19, 2026
Zero-dispatch full pass. Main GREEN (6c0b46c, #2012). Both open PRs
(#2009 harness LAPACKE, #2013 resistance-v2 study bundle) are
maintainer-authored active-LOCAL; every other track deep-warehouse /
human / maintainer-enablement gated. Reconciled margin-realism (M2 #2010
merged) + resistance-v2 (#2013 open) index rows.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dayfine added a commit that referenced this pull request Jul 19, 2026
Automated daily orchestrator run 3 of 2026-07-19 (GHA run 29701091765).
See `dev/daily/2026-07-19-run3.md`.

**Mode:** FULL PASS, ZERO dispatches. Main GREEN (`6c0b46c3`, #2012).
Both open PRs (#2009 harness LAPACKE, #2013 resistance-v2 study bundle)
are maintainer-authored active-LOCAL; every other track is
deep-warehouse-data-gated / human-gated / maintainer-enablement-gated.
Reconciled margin-realism (M2 #2010 merged; next M3–M4) + resistance-v2
(#2013 open) index rows. Health CLEAN (build+runtest+integrity+index all
exit 0). No `[drift]`, no still-real `[critical]`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
dayfine added a commit that referenced this pull request Jul 20, 2026
Automated daily orchestrator run (run-1 of 2026-07-20, GHA run
29719142253).

Zero-dispatch full pass. Main GREEN on `b4ef7900` (clean-tree `dune
build` + `dune runtest` both exit 0; fmt_check/magic_numbers OK;
integrity + index_size exit 0). One open PR #2009 (maintainer LOCAL,
deferred per collision-avoidance); every other track
deep-warehouse-data-gated / human-gated / active-LOCAL. Reconciled
resistance-v2 (#2013 merged + lever f #2015) and margin-realism (M3a/M3b
#2016/#2017) rows.

See `dev/daily/2026-07-20.md` for the full summary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
dayfine added a commit that referenced this pull request Jul 20, 2026
Automated daily orchestrator run 2 (GHA run 29738031830). Zero-dispatch
full pass — see `dev/daily/2026-07-20-run2.md`.

Main GREEN on HEAD `edcaa7c9` (build-and-test + perf-tier1-smoke =
success). The one open PR (#2009) is maintainer-authored active-LOCAL;
orchestrator defers per gha-local-coordination. All feature tracks
deep-warehouse-data-gated / human-gated; harness backlog
milestone/PAT-gated; cleanup empty; ops-data has no EODHD key.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
dayfine added a commit that referenced this pull request Jul 20, 2026
Automated daily orchestrator run (run 3 of 2026-07-20, GHA run
29748583702).

**FULL PASS — zero dispatches.** Main GREEN (HEAD `0e6430cb`; local
`dune build` exit 0; GHA `build-and-test` + `perf-tier1-smoke` =
success). Nothing landed on main since run-2's summary merge (#2019 =
HEAD). The one open PR (#2009, LAPACKE GP-Cholesky nugget fix) is
maintainer-authored active-LOCAL — orchestrator defers per
gha-local-coordination collision-avoidance.

Includes: run-3 daily summary, consolidated 3-run summary, run-3
`_index.md` reconcile (light — prose refresh only, no track drift), and
fast health report (CLEAN).

See `dev/daily/2026-07-20-run3.md` for the full summary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
dayfine added a commit that referenced this pull request Jul 20, 2026
Automated daily orchestrator run 4 of 2026-07-20 (GHA run 29773823318).

**FULL PASS — ZERO dispatches.** Step 0.5 saturated-queue fast-exit
correctly declined on Condition 2 (maintainer docs #2021 touched
`dev/status/resistance-v2.md` since run-3's summary). The full pass
re-confirmed runs 1-3: no dispatchable work.

- **Main GREEN** — HEAD `d6a65ed5` (#2021 maintainer docs); GHA
`build-and-test` + `perf-tier1-smoke` = success; local `dune build` exit
0; status_file_integrity + index_size exit 0.
- **2 open PRs, both maintainer-authored (dayfine)** — #2009 (harness
LAPACKE fix, active-LOCAL) and #2022 (weekly deep scan,
advisory/human-merged per T3-A+). Orchestrator does not QC/auto-merge
either.
- Every feature/experiment track deep-warehouse-data-gated
(EODHD_API_KEY absent) / human-gated / active-LOCAL. Harness + cleanup
backlogs have no dispatchable items. ops-data has no key + data-gaps
unchanged since #814.
- No `[drift]`, no still-real `[critical]`.

See `dev/daily/2026-07-20-run4.md` for the full summary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: claude-orchestrator <noreply@github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: GitHub Actions Bot <bot@github-actions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant