Skip to content

Added an option to manage cross section navigation - #9

Open
matcho wants to merge 3 commits into
davosmith:masterfrom
telabotanica:feat/dontcrosssections
Open

Added an option to manage cross section navigation#9
matcho wants to merge 3 commits into
davosmith:masterfrom
telabotanica:feat/dontcrosssections

Conversation

@matcho

@matcho matcho commented Aug 1, 2016

Copy link
Copy Markdown
Contributor

A proposal to address #8

Greetings,
Mathias

Comment thread db/install.xml
<FIELD NAME="backgroundcolour" TYPE="char" LENGTH="20" NOTNULL="false" DEFAULT="#6666cc" SEQUENCE="false" PREVIOUS="buttonstype" NEXT="customusebackground"/>
<FIELD NAME="customusebackground" TYPE="int" LENGTH="4" NOTNULL="true" UNSIGNED="true" DEFAULT="0" SEQUENCE="false" PREVIOUS="backgroundcolour" NEXT="homebuttonshow"/>
<FIELD NAME="homebuttonshow" TYPE="int" LENGTH="4" NOTNULL="true" UNSIGNED="true" DEFAULT="1" SEQUENCE="false" PREVIOUS="customusebackground" NEXT="homebuttontype"/>
<FIELD NAME="homebuttontype" TYPE="int" LENGTH="4" NOTNULL="true" UNSIGNED="true" DEFAULT="1" SEQUENCE="false" PREVIOUS="homebuttonshow" NEXT="firstbuttonshow"/>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not time to do a full review now - but why have you removed the homebuttontype field?

@matcho

matcho commented Aug 1, 2016

Copy link
Copy Markdown
Contributor Author

Mhh I guess it's because I screwed up with the file :)
Thanks for the feedback - I update the PR right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants