Skip to content

Protection against non-existing property "hiddensections" in $COURSE #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matcho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Protection against non-existing property "hiddensections" in $COURSE #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function draw_navbuttons() {
if ($mod->sectionnum > 0 && $sectionnum != $mod->sectionnum) {
$thissection = $sections[$mod->sectionnum];

if ($thissection->visible || !$COURSE->hiddensections ||
if ($thissection->visible || (property_exists($COURSE, "hiddensections") && !$COURSE->hiddensections) ||

@davosmith davosmith Aug 1, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'll have to look at this in more detail, but I'd be wanting to use isset(), not property_exists (possibly also wanting to use empty(), but would have to figure out the logic of the line of code first anyway).

has_capability('moodle/course:viewhiddensections', $context)
) {
$sectionnum = $mod->sectionnum;
Expand Down