Add Thunk.force and use it in wf jrunscript tests - #2450
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Preflight: loaded repository instructions from AGENTS.md; no personal instructions found at ~/.agents/README.md.
This PR adds a minimal thunk evaluator ($api.fp.Thunk.force) to the functional utilities and uses it to simplify the wf test.jrunscript flow by evaluating the produced thunk directly in the $api.fp.now(...) pipeline.
Changes:
- Add
$api.fp.Thunk.force(thunk) => thunk()toloader/$api-Function.js. - Extend the Fifty definitions/tests to cover
Thunk.force. - Refactor
wf.js’stest.jrunscriptimplementation to useThunk.forcein the pipeline instead of storing and calling an intermediate thunk.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wf.js | Refactors the jrunscript test runner to evaluate the thunk via $api.fp.Thunk.force within the existing $api.fp.now pipeline. |
| loader/$api-Function.js | Introduces Thunk.force as a minimal thunk evaluator. |
| loader/$api-Function.fifty.ts | Adds Thunk.force to the exported typings and includes Fifty test coverage validating repeated evaluation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$api.fp.Thunk.forceas a minimal thunk evaluator (Thunk<T> -> T)Thunk.forcewf test.jrunscriptflow inwf.jsto useThunk.forcein the pipelineValidation