Skip to content

fix: install optionalDependencies#98

Merged
davideicardi merged 6 commits into
masterfrom
codex/spiegare-la-struttura-del-codebase
Jun 4, 2025
Merged

fix: install optionalDependencies#98
davideicardi merged 6 commits into
masterfrom
codex/spiegare-la-struttura-del-codebase

Conversation

@davideicardi

@davideicardi davideicardi commented Jun 4, 2025

Copy link
Copy Markdown
Owner

FIX: #97

@davideicardi davideicardi marked this pull request as ready for review June 4, 2025 15:58
@davideicardi davideicardi requested a review from Copilot June 4, 2025 15:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for optionalDependencies in plugin installation by extending the core managers, updating tests, and documenting the new behavior.

  • Extend VersionManager and PluginManager to detect and install optional dependencies (ignoring failures).
  • Add end-to-end tests for successful and failed optional dependency installation.
  • Bump version to 1.1.0 and update README to mention optional dependency support.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/my-plugin-with-opt-dep/package.json Defines an optional dependency for test plugin
test/my-plugin-with-opt-dep/index.js Uses moment to verify optional dep installation
test/my-plugin-with-bad-opt-dep/package.json Defines a non-existent optional dependency
test/my-plugin-with-bad-opt-dep/index.js Simple export to verify install continues on failure
test/PluginManagerSuite.ts Adds TypeScript tests for optional dependencies
test/PluginManagerSuite.js Adds JavaScript tests and location assertions
src/VersionManager.ts Captures optionalDependencies from package.json
src/PluginManager.ts Refactors dependency installation to include optional deps
src/PluginInfo.ts Updates plugin info interface with optional deps
src/PackageInfo.ts Updates package info interface with optional deps
package.json Bumps package version to 1.1.0
README.md Documents optional dependency support

Comment thread src/PluginManager.ts
Comment thread src/PluginManager.ts
Comment thread test/PluginManagerSuite.js
Comment thread test/PluginManagerSuite.js
Comment thread test/PluginManagerSuite.js
@davideicardi davideicardi changed the title Add optionalDependencies support fix: install optionalDependencies Jun 4, 2025
@davideicardi davideicardi merged commit 175ef9a into master Jun 4, 2025
4 checks passed
@davideicardi davideicardi deleted the codex/spiegare-la-struttura-del-codebase branch June 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional dependencies are not installed

2 participants