fix: install optionalDependencies#98
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for optionalDependencies in plugin installation by extending the core managers, updating tests, and documenting the new behavior.
- Extend
VersionManagerandPluginManagerto detect and install optional dependencies (ignoring failures). - Add end-to-end tests for successful and failed optional dependency installation.
- Bump version to 1.1.0 and update README to mention optional dependency support.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/my-plugin-with-opt-dep/package.json | Defines an optional dependency for test plugin |
| test/my-plugin-with-opt-dep/index.js | Uses moment to verify optional dep installation |
| test/my-plugin-with-bad-opt-dep/package.json | Defines a non-existent optional dependency |
| test/my-plugin-with-bad-opt-dep/index.js | Simple export to verify install continues on failure |
| test/PluginManagerSuite.ts | Adds TypeScript tests for optional dependencies |
| test/PluginManagerSuite.js | Adds JavaScript tests and location assertions |
| src/VersionManager.ts | Captures optionalDependencies from package.json |
| src/PluginManager.ts | Refactors dependency installation to include optional deps |
| src/PluginInfo.ts | Updates plugin info interface with optional deps |
| src/PackageInfo.ts | Updates package info interface with optional deps |
| package.json | Bumps package version to 1.1.0 |
| README.md | Documents optional dependency support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: #97