Harden Types in Core Interfaces and Plugins#47
Conversation
- Refactored `src/core/interfaces.ts` to replace `any` with `unknown` and generic types for `RequestContext`, `DataSourceProvider`, `DataActionProvider`, `Trigger`, and related interfaces. - Updated `fetch`, `firestore`, `fs`, and `scheduler` plugins to implement the hardened interfaces, accepting `unknown` configuration and validating/casting it as needed. - Updated `src/core/prompt.ts` to use `unknown` for prompt sources and execution result, improving type safety propagation. - Updated `PREVENT_CONFLICTS.md` to mark "Harden Types" and "Decompose dataprompt.ts" as completed (Task 3 was verified as already completed in codebase). Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the "Harden Types" task from
PREVENT_CONFLICTS.md. It systematically replacesanywithunknownand generics in core interfaces (DataSourceProvider,DataActionProvider, etc.) and updates all default plugins to comply with the new stricter types. It also updatessrc/core/prompt.tsto respect these type changes. Additionally, it marks the completed tasks inPREVENT_CONFLICTS.md.PR created automatically by Jules for task 11825931770011135630 started by @davideast