Refactor Plugin Registration Logic#46
Conversation
…Manager - Extracted default plugin logic to `src/core/default-plugins.ts` - Updated `ConfigManager` to use `resolvePlugins` for merging defaults - Simplified `PluginManager` to only register provided plugins - Updated tests to explicitly provide default plugins where needed - Updated `PREVENT_CONFLICTS.md` to mark task as complete Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR refactors the plugin registration logic in the
datapromptlibrary.Previously,
PluginManagercontained hardcoded logic to inject default plugins (Firestore, Fetch, Scheduler) if they were missing. This created a tight coupling and duplicated logic found inConfigManager.This change:
src/core/default-plugins.tswhich exportsgetDefaultPlugins()andresolvePlugins().ConfigManagerto use this new module to ensure default plugins are present in the configuration.PluginManager, making it a "dumb" container that simply registers what it is given.PluginManagerwith explicit defaults where necessary).This completes the "Refactor Plugin Registration" task outlined in
PREVENT_CONFLICTS.md.PR created automatically by Jules for task 12190076701982729250 started by @davideast