Skip to content

Refactor Plugin Registration Logic#46

Merged
davideast merged 1 commit into
mainfrom
refactor-plugin-registration-12190076701982729250
Feb 22, 2026
Merged

Refactor Plugin Registration Logic#46
davideast merged 1 commit into
mainfrom
refactor-plugin-registration-12190076701982729250

Conversation

@davideast
Copy link
Copy Markdown
Owner

This PR refactors the plugin registration logic in the dataprompt library.

Previously, PluginManager contained hardcoded logic to inject default plugins (Firestore, Fetch, Scheduler) if they were missing. This created a tight coupling and duplicated logic found in ConfigManager.

This change:

  1. Creates src/core/default-plugins.ts which exports getDefaultPlugins() and resolvePlugins().
  2. Updates ConfigManager to use this new module to ensure default plugins are present in the configuration.
  3. Removes the default plugin injection logic from PluginManager, making it a "dumb" container that simply registers what it is given.
  4. Updates unit and integration tests to reflect this change (instantiating PluginManager with explicit defaults where necessary).

This completes the "Refactor Plugin Registration" task outlined in PREVENT_CONFLICTS.md.


PR created automatically by Jules for task 12190076701982729250 started by @davideast

…Manager

- Extracted default plugin logic to `src/core/default-plugins.ts`
- Updated `ConfigManager` to use `resolvePlugins` for merging defaults
- Simplified `PluginManager` to only register provided plugins
- Updated tests to explicitly provide default plugins where needed
- Updated `PREVENT_CONFLICTS.md` to mark task as complete

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@davideast davideast merged commit 34bbf8f into main Feb 22, 2026
1 check passed
@davideast davideast deleted the refactor-plugin-registration-12190076701982729250 branch February 22, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant