Refactor: Extract Genkit initialization to factory module#45
Conversation
Extracts `createDefaultGenkit` and `loadUserGenkitInstance` from `src/core/dataprompt.ts` into a new `src/core/genkit-factory.ts` module. This addresses the "Large Files and Responsibilities" issue in `PREVENT_CONFLICTS.md` and helps prevent merge conflicts by isolating initialization logic. Includes unit tests for the new factory module. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR extracts the Genkit initialization logic from
src/core/dataprompt.tsinto a newsrc/core/genkit-factory.tsfile.This change is part of the "Large Files and Responsibilities" improvement strategy outlined in
PREVENT_CONFLICTS.md. By isolatingcreateDefaultGenkitandloadUserGenkitInstance, we reduce the complexity of the maindatapromptentry point and minimize the risk of merge conflicts when modifying initialization logic or adding new plugins.Changes:
src/core/genkit-factory.ts.createDefaultGenkitandloadUserGenkitInstanceto the new factory.src/core/dataprompt.tsto use the new factory.tests/unit/genkit-factory.test.tsto verify the extracted logic.PR created automatically by Jules for task 6019131064566681597 started by @davideast