Skip to content

fix: preserve pdf scroll position on dark mode toggle #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natiyeshi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve pdf scroll position on dark mode toggle #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/screens/reading/widgets/pdf_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,10 @@ class _ReadingPdfViewState extends State<ReadingPdfView> {
duration: const Duration(milliseconds: 150),
curve: Curves.easeIn,
child: ColorFiltered(
key: ValueKey(widget.settings.theme),
// No key here: keying by theme would tear down and rebuild the
// PdfViewer subtree on every theme change, resetting scroll to the
// top. ColorFiltered updates its filter in place, so the viewer
// (and its scroll position) is preserved across theme switches.
colorFilter: colorFilter,
child: pdfViewer,
),
Expand Down