Skip to content

[codex] fix youshedubao import side effect #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
datehoer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] fix youshedubao import side effect #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions youshedubao/youshedubao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ def get_youshedubao_data():
doc = pyquery.PyQuery(res.content)
items = doc(".news-main>script").text()
uisdc_news = re.findall('var uisdc_news = "(.*?)";', items)[0]
uisdc_news = json.loads(uisdc_news.replace('\\"', '"').replace("\\\\", "\\"))
uisdc_news = json.loads(
uisdc_news.replace('\\"', '"').replace("\\\\", "\\").replace("\\'", "'")
)
Comment on lines +26 to +28

@gemini-code-assist gemini-code-assist Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using chained .replace() calls to unescape JS/JSON strings is fragile and can lead to corruption. For example, if the string contains a literal backslash followed by a single quote, the first replacement of double backslashes with a single backslash will convert it, and the subsequent replacement of escaped single quotes will incorrectly strip the backslash.\n\nA more robust and standard way to unescape all JS/Python-style escape sequences (like escaped quotes, backslashes, newlines, etc.) in a single pass is to use codecs.escape_decode.

Suggested change
uisdc_news = json.loads(
uisdc_news.replace('\\"', '"').replace("\\\\", "\\").replace("\\'", "'")
)
import codecs
uisdc_news = json.loads(
codecs.escape_decode(uisdc_news.encode("utf-8"))[0].decode("utf-8")
)

return {"data": uisdc_news}
print(get_youshedubao_data())


if __name__ == "__main__":
print(get_youshedubao_data())