Feature/add sqlmesh demo - #31
Open
Siyan-Luo wants to merge 39 commits into
Open
Conversation
Siyan-Luo
marked this pull request as ready for review
April 25, 2025 14:50
Comment on lines
+10
to
+15
| backend "s3" { | ||
| bucket = "terraform-states-dm" # manually created (the bootstrap problem), with versioning enabled (best practice) | ||
| key = "sqlmesh-demo" | ||
| region = "eu-west-1" | ||
| use_lockfile = true | ||
| } |
Contributor
There was a problem hiding this comment.
Hard-coded dependency that does not exist. Look at the global pre-requisites. I think we create an s3 bucket there that you might be able to re-use
There was a problem hiding this comment.
Thanks for seeing this. I have removed the hardcoded part, created a sample backend tf file (that users can copy and fill accordingly) and updated the readme accordingly adding this as a prerequisite.
| version = "0.1.0" | ||
| description = "Sample project using sqlmesh" | ||
| readme = "README.md" | ||
| authors = ["oliver.willekens@dataminded.com", "siyan.luo@dataminded.com"] |
Contributor
There was a problem hiding this comment.
Add your name here as well Jesus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.mdand sampleREADME.mdconveyor-samplesaws rolesamples_.conveyorfolder checked-in by mistake