feat: implement variant_length UDF - #61
Open
getChan wants to merge 3 commits into
Open
Conversation
getChan
force-pushed
the
feat/variant-length
branch
2 times, most recently
from
May 22, 2026 04:02
6e46ba7 to
36ac068
Compare
getChan
marked this pull request as draft
May 22, 2026 04:03
Member
|
Hi @getChan is this ready for a review? |
getChan
marked this pull request as ready for review
June 10, 2026 07:27
Contributor
Author
|
@friendlymatthew Added sqlogictests. Ready for review! |
friendlymatthew
left a comment
friendlymatthew
left a comment
Member
There was a problem hiding this comment.
Hi, we just recently pushed a PR that bumps deps. You may want to rebase
Closes datafusion-contrib#41 Returns the number of elements in a Variant Array or Object at the given path. Returns NULL for non-array/object variants or NULL inputs. - variant_length(VariantArray, path) -> UInt64 (Nullable) - Supports scalar and columnar variant inputs with scalar path - 5 unit tests covering array, object, nested path, primitive->NULL, columnar
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
getChan
force-pushed
the
feat/variant-length
branch
from
June 10, 2026 08:04
b6c4e5d to
12caa5e
Compare
Contributor
Author
|
Rebased. Some tests are failing, but they are outside the scope of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Summary
Implements
variant_length(VariantArray, path)as described in #41.Returns the number of elements in a Variant Array or Object at the given path. Returns
NULLfor non-array/object variants (e.g. primitives) orNULLinputs.Return type
UInt64(Nullable)Behavior
[1, 2, 3]at""3{"a": 1, "b": 2}at""2{"a": [1,2,3,4]}at"a"442(primitive)NULLNULLvariantNULLTests
5 unit tests covering scalar array, scalar object, nested path, primitive→NULL, and columnar input.