Feat/2.6.0 beta4#2161
Merged
Merged
Conversation
…rge & skill naming - Add display_name / skill ID (name) dual-field definition for skills - Add §4.8: merge Linsight workbench tab into daily tab (entry switch removed, task-mode naming, shared tool config, SOP library -> skill mgmt) - Downgrade migration reconciliation report to ops summary log (AC-4) - Restructure "+" menu into general-context and task-mode groups Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the branding/theme customization flow to better support a configurable loading icon (including runtime/client boot loading), improves deletion behavior for uploaded assets, and adds simple invalid-character validation for the system brand name.
Changes:
- Set default loading icon in the platform brand config and expose it consistently via
URLLoadingIcon/loading.icon. - Improve asset deletion UX/state handling by passing whether the deleted option was currently selected.
- Add brand-name validation for
</>and update related i18n messages; update client loading UI to render the configured loading icon early.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/platform/src/pages/SystemPage/theme/brandTypes.ts | Sets a default loading icon object and default URLLoadingIcon. |
| src/frontend/platform/src/pages/SystemPage/theme/BrandPreviewPanel.tsx | Removes the redundant brand-name block in the login preview layout. |
| src/frontend/platform/src/pages/SystemPage/theme/BrandCustomization.tsx | Adds brand-name invalid character guard; updates asset deletion handlers to receive deletedWasSelected. |
| src/frontend/platform/src/pages/SystemPage/theme/BrandAssetUpload.tsx | Updates onDeleted callback signature and suppresses unintended selection changes during delete interactions. |
| src/frontend/platform/public/locales/zh-Hans/bs.json | Updates URL-invalid message; adds brand-name invalid-character message. |
| src/frontend/platform/public/locales/ja/bs.json | Updates URL-invalid message; adds brand-name invalid-character message. |
| src/frontend/platform/public/locales/en-US/bs.json | Updates URL-invalid message; adds brand-name invalid-character message. |
| src/frontend/platform/public/assets/bisheng/config.js | Adds loading object with icon/iconOptions/animation to the runtime brand config. |
| src/frontend/client/src/components/ui/icon/Loading/index.tsx | Uses runtime brand config to render a custom loading icon image when configured. |
| src/frontend/client/public/assets/bisheng/config.js | Mirrors the runtime brand config loading object for the client app. |
| src/frontend/client/index.html | Adds an early boot loading <img> and script to resolve/set the configured loading icon URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
29
| export const LoadingIcon = forwardRef< | ||
| SVGSVGElement & { className: any }, | ||
| (SVGSVGElement | HTMLImageElement) & { className: any }, | ||
| React.PropsWithChildren<{ className?: string }> | ||
| >(({ className, ...props }, ref) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.