fix: sidebar Focus list no longer truncates at 12 items without expand option#677
Merged
Conversation
…d option - Replace static slice(0,12) in renderFocusGroup with collapsible show-more - Add showAllSideActive / showAllSideSystem / showAllSideCompleted state vars - In-progress and System Focus groups show counter badge (e.g. 12/20) and a 'Show more (+N)' / 'Show less' toggle button when items exceed 12 - Completed group also gains same expand/collapse; collapses back to 12 when the parent 'Hide completed' button is toggled - SIDE_FOCUS_LIMIT constant (12) co-located with renderFocusGroup for clarity Fixes: sidebar Focus items beyond position 12 were invisible and unmanageable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar Aware tab's Focus list had a hardcoded
slice(0, 12)inrenderFocusGroupwith no expand button. Any Focus items beyond position 12 (In progress, System Focus, and Completed groups) were completely invisible and unmanageable in the sidebar.Root Cause
renderFocusGroup(sidebar-only helper at ~L4451) was a static renderer with no expand state, unlike the main Aware tab which already usesshowAllFocus+SECTION_PAGE_SIZE.Fix
showAllSideActive,showAllSideSystem,showAllSideCompletedrenderFocusGroupto acceptshowAll/setShowAllprops12/N) in the subtitle and aShow more (+N)/Show lesstoggle button at the bottom of the groupTesting
tsc --noEmit --skipLibCheckpasses with zero errors