Eurostat Data Import - Death by week and sex & Divorce indicators#2039
Open
pravnkumar-cloudsufi wants to merge 3 commits into
Open
Eurostat Data Import - Death by week and sex & Divorce indicators#2039pravnkumar-cloudsufi wants to merge 3 commits into
pravnkumar-cloudsufi wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new Eurostat data imports for weekly deaths and divorce indicators, providing documentation, configuration, and automation scripts. The review identifies several critical issues, including incorrect file paths in the download scripts and missing output columns required for data consistency. Suggestions were also provided to use ISO 8601 week formats for dates to prevent collisions, standardize ratio mappings, and correct markdown formatting in the README files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist: https://drive.google.com/corp/drive/folders/19uraIXjS3R5bE7_NK8Xl_keFZCZspD5i?resourcekey=0-bEZP1Iy-DmoyBOK3Bmw6yQ