Skip to content

Eurostat Data Import - Death by week and sex & Divorce indicators#2039

Open
pravnkumar-cloudsufi wants to merge 3 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:eurostat_data_death_divorce
Open

Eurostat Data Import - Death by week and sex & Divorce indicators#2039
pravnkumar-cloudsufi wants to merge 3 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:eurostat_data_death_divorce

Conversation

@pravnkumar-cloudsufi
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new Eurostat data imports for weekly deaths and divorce indicators, providing documentation, configuration, and automation scripts. The review identifies several critical issues, including incorrect file paths in the download scripts and missing output columns required for data consistency. Suggestions were also provided to use ISO 8601 week formats for dates to prevent collisions, standardize ratio mappings, and correct markdown formatting in the README files.

Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/deaths_by_week_and_sex_pvmap.csv Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/run.sh Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/run.sh Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/run.sh Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/run.sh Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/README.md Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/README.md Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/divorce_indicators_pvmap.csv Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants