Use asynchronous aggregation queries#2030
Open
vish-cs wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery aggregation process to run asynchronously, introducing new methods for job submission and status polling across the BigQueryExecutor, AggregationUtils, and the ingestion workflow. Feedback identifies a logic error in get_jobs_status where a 'FAILED' status could be incorrectly overwritten by 'RUNNING' due to iteration order. Additionally, it is recommended to restore the 1800-second timeout in the workflow YAML to prevent premature timeouts during the initial job submission phase if the import list is large.
SandeepTuniki
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.