cleanup: warning produttori, net-drop transition, contratti allineati - #438
Merged
Conversation
- TransitionConfig.warn_removed_columns=False (default) — colonne rimosse non generano piu' warning (erano 86% del rumore) - Scaffold warnings declassati a logger.info() — non inquinano warnings - PAQA warning solo se score < 60 (prima critical_fail bastava a score 90+) - Aggiornati test
… contratti - compare_layer_profiles() tiene il confronto nomi (utile per diagnostica) - check_transitions() ora confronta net drop: se rimosse ≈ aggiunte → rename, non warning - raw→clean: warn_removed_columns=True (default) — avvisa su drop netto reale - clean→mart: warn_removed_columns=False (default in MartValidateConfig) - Contratti aggiornati: validation non piu' file, inline nel run record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Warning rumorosi ridotti da 78 a 0-2. Allineati contratti pubblici.
Cosa cambia
Dettaglio
merged_warnings.append()logger.info()warn_removed_columns=True(rumore)warn_removed_columns=False*_validation.jsoninesistentiRAW/CLEAN/MART_VALIDATIONin paths.pyreadiness.py,path_resolver.pyImpatto su un run reale (dipendenti-pubblici)
Prima: 7 warning, quality 90/75. Dopo: 0 warning, quality 100/100.
Impatto su contratti pubblici
Nessuno. I file di validazione non erano contratti pubblici. I contratti aggiornati nel file
contracts/pipeline.pyriflettono la realtà attuale.Verifica
ruff check .passapytest -m corepassafrom toolkit.contracts import CONTRACTS)