Skip to content

feat: download(url) -> bytes standalone (closes #68)#70

Merged
Andreacnt merged 2 commits into
mainfrom
feat/download-function
Jul 14, 2026
Merged

feat: download(url) -> bytes standalone (closes #68)#70
Andreacnt merged 2 commits into
mainfrom
feat/download-function

Conversation

@Gabrymi93

Copy link
Copy Markdown
Member

Sintesi

Funzione standalone download(url, *, timeout=60, proxy_from_env=True, max_retries=2) -> bytes per script che vogliono scaricare dati senza istanziare HttpClient.

Cosa cambia

  • Nuovo modulo lab_connectors/http/download.py
  • Esportato in lab_connectors.http.__init__
  • 6 test (success, HTTP error, connection error, empty URL, proxy, no proxy)

Uso

from lab_connectors.http import download

# Invece di 7 righe di urllib
data = download(url, timeout=120)
# Ha già retry, proxy, TLS 1.2, curl, urllib (da #67)

Verifica

python -m pytest tests/http/test_download.py -v

6 passati, 0 falliti.

Closes #68

@Gabrymi93

Copy link
Copy Markdown
Member Author

Review fix: rimosso proxy_from_envHttpClient gestisce già il proxy internamente. download() ora è un wrapper puro senza logica proxy.

4 test (success, HTTP error, connection error, empty URL). proxy non si testa più perché è responsabilità di HttpClient, non di download().

@Gabrymi93
Gabrymi93 requested a review from Andreacnt July 14, 2026 12:37
@Andreacnt
Andreacnt merged commit 06e8b0f into main Jul 14, 2026
2 checks passed
@Andreacnt
Andreacnt deleted the feat/download-function branch July 14, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(http): funzione standalone download(url) -> bytes

2 participants