builder/stream_builder: validate UC three-part table name format in validate()#332
Open
Dev-X25874 wants to merge 2 commits into
Open
builder/stream_builder: validate UC three-part table name format in validate()#332Dev-X25874 wants to merge 2 commits into
Dev-X25874 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
WHAT:
StreamBuilder::validate()now checks that the table name follows therequired
catalog.schema.tableformat, returningZerobusError::InvalidTableNameimmediately if it does not.
WHY:
validate()previously only checked that the table name was non-empty.A malformed name like
"mytable"or"schema.table"would passvalidate()andbuild(), only to fail later inside the async OAuth token fetch — far from themisconfigured builder. The three-part invariant was already enforced in
DefaultTokenFactory::parse_table_name; this PR moves that check to the earliestpossible point so the error fires synchronously, before any I/O occurs.
How is this tested?
Three unit tests added to the existing
#[cfg(test)]block instream_builder.rs:validate_rejects_single_part_table_namevalidate_rejects_two_part_table_namevalidate_rejects_table_name_with_empty_partAll three fail on the original code and pass after the fix.