DBSQL for Dimension ETL#127
Open
shyamraodb wants to merge 43 commits into
Open
Conversation
…ate/Patient Dimension ETL w CDF.sql
Collaborator
QuentinAmbard
left a comment
Collaborator
There was a problem hiding this comment.
hey, I did a few style / sql comment, I'll do another pass on the flow/logic after, let's catchup next week to review it? Thanks!
Collaborator
There was a problem hiding this comment.
we need to review this and use the python SDK instead if it's part of the demo, or instead we move it within the bundle file and the workflow got created automatically and we don't expose this file to the user - let's talk about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Demo of SCD Type2 ETL using DBSQL:
Added folder dbsql-for-dim-etl under product_demos/DBSQL-Datawarehousing.
Included notebooks, images, csv files corresponding to demo.